Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting in readme.md #2722

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Fix formatting in readme.md #2722

merged 1 commit into from
Mar 14, 2023

Conversation

leonvogt
Copy link
Contributor

@leonvogt leonvogt commented Mar 1, 2023

Very small PR that fixes a formatting bug in README.md.

  1. The Travel link on line 41 didn't worked, because the Travel title was collapsed inside the Creature section.
  2. Without knowing I wouldn't expect that the Travel section would be inside of Creature.

Before:
image

After:
image

jremes-foss
jremes-foss approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@jremes-foss jremes-foss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM. This works now. Thank you!

@thdaraujo thdaraujo merged commit 6ce775b into faker-ruby:main Mar 14, 2023
@thdaraujo
Copy link
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jremes-foss jremes-foss jremes-foss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leonvogt @thdaraujo @jremes-foss