add digits to password

[wyattroyc]

Summary

Adds digits to generated passwords

Fixes Issue #2704

Other Information

[MicBruz]

Hi! Thank you for the PR!
Shouldn't we consider adding digits as an additional parameter (as special characters), since all that time it was not including digits?
Or we just treat it as a bug and go with documentation?

[wyattroyc]

I'm leaning towards treating it as a bug instead of passing digits as a parameter and having to update the documentation, but I think either way works!

[MicBruz]

I think that might be already covered by the test test_password_with_mixed_case in the line 153 (148 on the main).

[stefannibrasil]

I think it's okay to have it here as well because this is testing the case of when there is no mix case argument.

[stefannibrasil]

Shouldn't we consider adding digits as an additional parameter (as special characters), since all that time it was not including digits?

Not really! This is a bug. The generator is intended to use digits, and not as a parameter. Fixing the bug with regression tests is the solution here.

[stefannibrasil]

hi @wyattroyc thanks for submitting a PR and for the patience. I will merge this as it fixes the bug.

Unfortunately, the tests don't seem to be exercising the code as we'd expect. For example, if you simply change the expectation here:

  def test_password
    assert_match(/\w{3}/, @tester.password)
  end

to expect any number, the test pass. I have some ideas to improve the tests to catch those bugs and have a reliable test suite for this generator. For now, thank you for the contribution!

and thank you @MicBruz for the comments!

[stefannibrasil]

I think it's okay to have it here as well because this is testing the case of when there is no mix case argument.