-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spongebob TV show collections #2619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌊
🍍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha this is great, thanks for the PR!
I left a few suggestions.
@thdaraujo I addressed the comments and reran tests & linting locally. Should be good to go! On a side note, I've seen your name on the patch.io repo quite a bit from the early days. Nice to finally meet you! |
nice to meet you too, James! Hope my code didn't cause you too much trouble 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thdaraujo heads up that this change didn't make it in the 3.0.0 release but the readme on main has the docs |
hey @kleinjm that's expected. We merged your changes after the v3 release, but it will be included in the next one. 😊 Thanks! |
Summary
Adds Spongebob TV show collections of characters, quotes, and episodes