Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Duplicate array before concatenating #2500

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

mattr
Copy link
Contributor

@mattr mattr commented Jun 21, 2022

Issue#

No-Story

Description:

Arrays are frozen, so instead of modifying the original array, duplicate in order to concatenate the data sets.

Arrays are frozen, so instead of modifying the original array, duplicate in order to concatenate the data sets.
@koic koic merged commit 9e54d59 into faker-ruby:master Jun 21, 2022
@koic
Copy link
Member

koic commented Jun 21, 2022

👍

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @mattr thanks for fixing this spec!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants