Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Phish Albums and Musicians #2024

Merged
merged 9 commits into from
May 31, 2020
Merged

Added Phish Albums and Musicians #2024

merged 9 commits into from
May 31, 2020

Conversation

zfine416
Copy link
Contributor

Issue#
No-Story

Description:

Added
Faker::Phish.musicianwhich returns a random musician in Phish
and
Faker::Phish.album which returns a random phish album

I also took the time to update the format of the yml file
New tests are included

Zeragamba
Zeragamba suggested changes May 30, 2020
View reviewed changes
lib/faker/music/phish.rb Outdated Show resolved Hide resolved
@zfine416 zfine416 requested a review from Zeragamba May 30, 2020 14:59
lucasqueiroz
lucasqueiroz approved these changes May 31, 2020
View reviewed changes
Copy link
Member

@lucasqueiroz lucasqueiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@Zeragamba Zeragamba merged commit 2e46998 into faker-ruby:master May 31, 2020
@Zeragamba
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koic koic koic approved these changes

@Zeragamba Zeragamba Zeragamba approved these changes

@lucasqueiroz lucasqueiroz lucasqueiroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zfine416 @Zeragamba @koic @lucasqueiroz