Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding explicit UTF-8 encoding while reading readme, license and requirements file. #269

Merged
merged 1 commit into from
May 18, 2021

Conversation

Amit-GH
Copy link

@Amit-GH Amit-GH commented May 17, 2021

Issue: #268

Testing:
Issue is seen in Python-3.6.9 and goes away with this fix.
Issue is not seen in Python-3.8.2 and doesn't get impacted by this fix.

…irements file.

Testing:
Issue is seen in Python-3.6.9 and goes away with this fix.
Issue is not seen in Python-3.8.2 and doesn't get impacted by this fix.
@facebook-github-bot
Copy link

Hi @Amit-GH!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ajfisch ajfisch merged commit 6d7c1b7 into facebookresearch:master May 18, 2021
Amit-GH added a commit to Amit-GH/DrQA that referenced this pull request May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants