Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler][be] Less ambiguous error messages for validateMemo bailout #30601

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 11:22pm

Copy link
Contributor

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. The dependency one is very clear, for the “value not memoized” case it might be nice to explain why “(because it may be mutated later)” but I like how you’re clarifying the two cases.

suggestions: null,
});
}
}
}
if (value.kind === 'FinishMemoize') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: else if

@mofeiZ mofeiZ merged commit 64701b6 into gh/mofeiZ/14/base Aug 8, 2024
19 checks passed
mofeiZ added a commit that referenced this pull request Aug 8, 2024
ghstack-source-id: 312093ec74d733bccd2d2d8400eaba267c9e33a7
Pull Request resolved: #30601
@mofeiZ mofeiZ deleted the gh/mofeiZ/14/head branch August 8, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants