Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[useEvent] Lint for presence of useEvent functions in dependency lists #25512

Merged
merged 3 commits into from
Oct 19, 2022
Merged

[useEvent] Lint for presence of useEvent functions in dependency lists #25512

merged 3 commits into from
Oct 19, 2022

Commits on Oct 19, 2022

  1. [useEvent] Lint for presence of useEvent functions in dependency lists 

    With #25473, the identity of useEvent's return value is no longer stable
across renders. Previously, the ExhaustiveDeps lint rule would only
allow the omission of the useEvent function, but you could still add it
as a dependency.

This PR updates the ExhaustiveDeps rule to explicitly check for the
presence of useEvent functions in dependency lists, and emits a warning
and suggestion/autofixer for removing the dependency.
    @poteto
    poteto committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    67f600d View commit details
    Browse the repository at this point in the history

  2. Address feedback on lint message

    @poteto
    poteto committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    29a09d7 View commit details
    Browse the repository at this point in the history

  3. s/wrapped in/returned from/

    @poteto
    poteto committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    d2eed48 View commit details
    Browse the repository at this point in the history