Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release script filters DevTools NPM packages #16810

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Sep 17, 2019

Tested by publishing CI build 44948 as canary 0.0.0-b4b8a349a

@@ -49,8 +57,7 @@ const getArtifactsList = async buildID => {
process.env.CIRCLE_CI_API_TOKEN
}`;
const workflowMetadata = await http.get(workflowMetadataURL, true);

const job = workflowMetadata.jobs.find(
const job = workflowMetadata.items.find(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure when this changed, but the metadata URL seems to now return workflowMetadata.items rather than workflowMetadata.jobs.

@sizebot
Copy link

sizebot commented Sep 17, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 2752ed8

@bvaughn bvaughn merged commit e8c7dde into facebook:master Sep 17, 2019
@bvaughn bvaughn deleted the release-script-ignore-devtools branch September 17, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants