Update ignore file to include ReactBuildConfig in the npm package
#45279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cortinico
approved these changes
Jul 4, 2024
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@j-piasecki can you also open a pick request for this one? |
|
@cortinico merged this pull request in b289854. |
|
This pull request was successfully merged by @j-piasecki in b289854. When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
Jul 8, 2024
…45279) Summary: Changes `.npmignore` file to only exclude the `ReactAndroid/build` directory instead of all `build` directories under `ReactAndroid` (which included the `ReactAndroid/src/main/java/com/facebook/react/common/build` package). This problem was caused by the newer version of NPM being used. Closes #45204 ## Changelog: [ANDROID] [FIXED] - Fixed build from source failing due to a missing file Pull Request resolved: #45279 Test Plan: Run `npm pack` or `npm publish -dry-run`. Before this change it includes 3774 files in the package and `ReactBuildConfig` isn't included. After this change it includes 3775 files in the package and `ReactBuildConfig` is included. Reviewed By: javache Differential Revision: D59371555 Pulled By: cortinico fbshipit-source-id: f54f1e88e30429d538b9e160e6ce20d994c5d1b8
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changes
.npmignorefile to only exclude theReactAndroid/builddirectory instead of allbuilddirectories underReactAndroid(which included theReactAndroid/src/main/java/com/facebook/react/common/buildpackage). This problem was caused by the newer version of NPM being used.Closes #45204
Changelog:
[ANDROID] [FIXED] - Fixed build from source failing due to a missing file
Test Plan:
Run
npm packornpm publish -dry-run.Before this change it includes 3774 files in the package and
ReactBuildConfigisn't included. After this change it includes 3775 files in the package andReactBuildConfigis included.