fix: on iOS not getting 304 from If-None-Match request
#45263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 3c6762a |
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@dmytrorykun merged this pull request in b8ab0fe. |
|
This pull request was successfully merged by @huzhanbo1996 in b8ab0fe. When will my fix make it into a release? | How to file a pick request? |
hakonk
reviewed
Jul 8, 2024
| @@ -365,6 +365,12 @@ - (RCTURLRequestCancellationBlock)buildRequest:(NSDictionary<NSString *, id> *)q | |||
| forHTTPHeaderField:@"Content-Length"]; | |||
| } | |||
|
|
|||
| // NSRequest default cache policy violate on `If-None-Match`, should allow the request | |||
| // to get 304 from server. | |||
| if (request.allHTTPHeaderFields[@"If-None-Match"]) { | |||
There was a problem hiding this comment.
This is case sensitive. Will there be cases where these headers come with lower casing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In #44483
If-None-Matchrequest failed to get a 304 after a 200 response. This is caused by NSRequest'scachePolicy which prevents sending a request to server to check 304 state and return directly a 200 response.
Changelog:
[IOS] [FIXED] - fix: on iOS not getting 304 from
If-None-MatchrequestTest Plan:
repeat request given in #44483