Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New implementation of PerformanceObserver and related APIs (fixes #45122) #45206

Closed
wants to merge 60 commits into from
Closed

New implementation of PerformanceObserver and related APIs (fixes #45122) #45206

wants to merge 60 commits into from

Commits on Sep 20, 2024

  1. refactor: extract performance observers to native layer and push entr… 

    …ies to each observer

refactor: use map for user timing API for better performance
    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5129b07 View commit details
    Browse the repository at this point in the history

  2. update JS code to reflect native changes

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    df5cade View commit details
    Browse the repository at this point in the history

  3. chore: undo CMakeLists change

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2a47fdc View commit details
    Browse the repository at this point in the history

  4. fix: wrap Plugins.h include into ifdef 

    fix: clear Observer native state
fix: reset observer entryTypes on change
    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    cecdd2f View commit details
    Browse the repository at this point in the history

  5. chore: add comment on PerformanceObserver TurboModule inclusion

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b4c02b3 View commit details
    Browse the repository at this point in the history

  6. fix: use type from timing/Primitives

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    cc46c94 View commit details
    Browse the repository at this point in the history

  7. fix reporting logic for entries of event type

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ae9c73b View commit details
    Browse the repository at this point in the history

  8. fix: handle LongTask in getBuffer() switch

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b8705e4 View commit details
    Browse the repository at this point in the history

  9. fix: use DOMHighResTimestamp

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7819498 View commit details
    Browse the repository at this point in the history

  10. fix: remove checking for duration threshold in observer and move filt… 

    …ering of observer event types to observer registry
    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a4e404d View commit details
    Browse the repository at this point in the history

  11. fix: remove const ref getEventFilter and add [[nodiscard]] attributes

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2b0f107 View commit details
    Browse the repository at this point in the history

  12. feat: add [[nodiscard]] attributes

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    284971e View commit details
    Browse the repository at this point in the history

  13. feat: add [[nodiscard]] attributes; clean up data flow to make it sim… 

    …pler
    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    751aba1 View commit details
    Browse the repository at this point in the history

  14. reorganize files; clean up logic; split PerformanceEntry buffers

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    30642ec View commit details
    Browse the repository at this point in the history

  15. improve PerformanceObserver options bridging

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6862527 View commit details
    Browse the repository at this point in the history

  16. chore: prettify Performance Observer public API

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    863d50e View commit details
    Browse the repository at this point in the history

  17. chore: moved PushStatus back to BoundedConsumableBuffer

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    dbf0775 View commit details
    Browse the repository at this point in the history

  18. chore: add more comments about testing only code

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6e0319c View commit details
    Browse the repository at this point in the history

  19. chore: add comment about divergence vs the spec

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f3450b6 View commit details
    Browse the repository at this point in the history

  20. fix: narrow down the public API and move the responsibility of filter… 

    …ing to PerformanceObserver from PerformanceObserverRegistry
    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    13f1200 View commit details
    Browse the repository at this point in the history

  21. chore: remove unnecessary [[nodiscard]] attirubtes

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    573b329 View commit details
    Browse the repository at this point in the history

  22. chore: rename PerformanceObserverRegistry::emit to `queuePerformanc… 

    …eEntry`
    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b2f039a View commit details
    Browse the repository at this point in the history

  23. chore: add OpaqueNativeObserverHandle type

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f613d44 View commit details
    Browse the repository at this point in the history

  24. chore: remove generic pushEntry from PerformanceEntryReporter

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8e1217d View commit details
    Browse the repository at this point in the history

  25. chore: bring back public getBuffer

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    254613f View commit details
    Browse the repository at this point in the history

  26. fix: multiple types buffering is not allowed

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b7a1732 View commit details
    Browse the repository at this point in the history

  27. fix: update JS layer; make observer buffer a vector; support `duratio… 

    …nThreshold`
    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    574fa98 View commit details
    Browse the repository at this point in the history

  28. fix: update native and JS layer

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6dc3b4a View commit details
    Browse the repository at this point in the history

  29. fix: make performance observer inherit from NativeState

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6a12b19 View commit details
    Browse the repository at this point in the history

  30. fix: tests

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6056aa7 View commit details
    Browse the repository at this point in the history

  31. chore: cleanup PerformanceObserver and PerformanceObserverRegistry de… 

    …pendency
    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e0aa0a2 View commit details
    Browse the repository at this point in the history

  32. chore: cleanup PerformanceObserver and PerformanceObserverRegistry de… 

    …pendency
    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a2f54b1 View commit details
    Browse the repository at this point in the history

  33. chore: style fixes

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1452d44 View commit details
    Browse the repository at this point in the history

  34. chore: narrow down CircularBuffer API

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    11ebbef View commit details
    Browse the repository at this point in the history

  35. chore: remove LinearBuffer and pendingMessagesCount

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9a59aec View commit details
    Browse the repository at this point in the history

  36. chore: fix getEventCounts position

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a1f7bb6 View commit details
    Browse the repository at this point in the history

  37. chore: fix lock_guard initialization style

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    187be80 View commit details
    Browse the repository at this point in the history

  38. style: rename entriesMutex_ to buffersMutex_

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a2bf9cf View commit details
    Browse the repository at this point in the history

  39. fix: remove concept of consuming, renamed BoundedConsumableBuffer t… 

    …o `CircularBuffer`, cleaned up buffer API
    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1cc3928 View commit details
    Browse the repository at this point in the history

  40. chore: remove allEntries cache from keyed buffer

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    771537e View commit details
    Browse the repository at this point in the history

  41. fix: refactor EntryReporter public API

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    88cc8ad View commit details
    Browse the repository at this point in the history

  42. style: format code

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a8cbb48 View commit details
    Browse the repository at this point in the history

  43. chore: make add/removeObserver part of registry public API

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    40b6200 View commit details
    Browse the repository at this point in the history

  44. chore: remove getNextOverwriteCandidate

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    055ae21 View commit details
    Browse the repository at this point in the history

  45. fix: schedule buffer flush only when its not empty

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4a9372c View commit details
    Browse the repository at this point in the history

  46. chore: cleanup optionals as arguments

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8c987ab View commit details
    Browse the repository at this point in the history

  47. chore: remove vector after clearing elements by name

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    d22f590 View commit details
    Browse the repository at this point in the history

  48. chore: remove pointer aliases, make PerformanceObserver shared instea… 

    …d of owned
    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    dfd9413 View commit details
    Browse the repository at this point in the history

  49. style: fix

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8d78ccd View commit details
    Browse the repository at this point in the history

  50. style: update comment

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    56d04ab View commit details
    Browse the repository at this point in the history

  51. chore: remove default max size from circular buffer

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fb3197c View commit details
    Browse the repository at this point in the history

  52. fix: optimize JS native call

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    23802a4 View commit details
    Browse the repository at this point in the history

  53. fix: tests

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8fe46c2 View commit details
    Browse the repository at this point in the history

  54. fix: tests

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4f4f6b3 View commit details
    Browse the repository at this point in the history

  55. undo testing stuff

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8f717c0 View commit details
    Browse the repository at this point in the history

  56. fix if condition

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ecf035a View commit details
    Browse the repository at this point in the history

  57. remove weak ptrs from registry;

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3b20278 View commit details
    Browse the repository at this point in the history

  58. remove clearing the observer in native module

    @robik
    robik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    aeba178 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. rename logEvent to testOnly_logEvent in NativePerformanceObserver

    @robik
    robik committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    8cfb905 View commit details
    Browse the repository at this point in the history

  2. style: fix

    @robik
    robik committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f136f65 View commit details
    Browse the repository at this point in the history