[PropTypes -> Flow] Split PointPropType #21355
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
| export type PointProp = $ReadOnly<{ | ||
| x: number, | ||
| y: number, | ||
| }>; | ||
|
|
||
| module.exports = PointPropType; | ||
| module.exports = PointProp; |
There was a problem hiding this comment.
Cannot reference type PointProp [1] from a value position.
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@peaonunes merged commit f3c8027 into Once this commit is added to a release, you will see the corresponding version tag below the description at f3c8027. If the commit has a single |
hramos
removed
Import Started
Summary: This PR split PointPropType.js into PointPropType.js with Flow definition and Libraries/DeprecatedPointPropType.js remaining with PropTypes definition. Related to facebook#21342 Pull Request resolved: facebook#21355 Differential Revision: D10081399 Pulled By: TheSavior fbshipit-source-id: 2283ff3fbda6b0f525742336f92fd6279250b874
This PR split PointPropType.js into PointPropType.js with Flow definition and Libraries/DeprecatedPointPropType.js remaining with PropTypes definition.
Related to #21342
Test Plan:
All flow tests succeed.
Release Notes:
[GENERAL] [ENHANCEMENT] [PointPropType.js] - Flow types only.
[GENERAL] [ENHANCEMENT] [Libraries/DeprecatedPropTypes/DeprecatedPointPropType.js] - Created deprecated PropType reference.