Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): Simplify styling for classic template landing page #1528

Merged
merged 4 commits into from
May 29, 2019

Conversation

wgao19
Copy link
Contributor

@wgao19 wgao19 commented May 29, 2019

Motivation

Simplify styling for classic landing page with a few responsive fixes:

  • Set min height to both sections on the first screen
  • Display only the header section when the viewport is not tall enough
  • Remove hardcoded media query but match infima screen width break points

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Landing page responsivity

Related PRs

NA

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 29, 2019
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented May 29, 2019

Deploy preview for docusaurus-2 ready!

Built with commit 722e634

https://deploy-preview-1528--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented May 29, 2019

Deploy preview for docusaurus-preview ready!

Built with commit 722e634

https://deploy-preview-1528--docusaurus-preview.netlify.com


# generated files
.docusaurus
.cache-loader
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added this

@endiliey endiliey merged commit a8e494d into master May 29, 2019
@endiliey endiliey deleted the wgao19/fix-landing-page-styling branch May 29, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants