refactor(v2): simplify code by removing wip i18n & translation #1431
Conversation
| @@ -15,7 +15,7 @@ module.exports = { | |||
| moduleNameMapper: { | |||
| '^@lib/(.*)$': '<rootDir>/packages/docusaurus/lib/$1', | |||
| }, | |||
| testPathIgnorePatterns: ['/node_modules/', '__fixtures__'], | |||
| testPathIgnorePatterns: ['loadSetup.js', '/node_modules/', '__fixtures__'], | |||
There was a problem hiding this comment.
loadSetup is an utility test function to help me setup fixtures easily.
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| import '@babel/polyfill'; | |||
| import path from 'path'; | |||
| import loadSetup from '../../../docusaurus/test/loadSetup'; | |||
| import loadSetup from '../../../docusaurus/lib/server/load/__tests__/loadSetup'; | |||
There was a problem hiding this comment.
Maybe we'll create @docusaurus/test-utils in the future to easily load up fixtures. Not going to do it in this PR.
endiliey
changed the title
endiliey
added
the
status: don't merge yet
|
Deploy preview for docusaurus-2 ready! Built with commit c51d902 |
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| import '@babel/polyfill'; | |||
| import path from 'path'; | |||
| import loadSetup from '../../../docusaurus/test/loadSetup'; | |||
| import loadSetup from '../../../docusaurus/lib/server/load/__tests__/loadSetup'; | |||
There was a problem hiding this comment.
Perhaps we should create test utils as separate modules. It's quite fragile for packages to cross module boundaries like this and import from other modules via relative paths.
There was a problem hiding this comment.
was thinking of that as well. Gonna do it soon, this PR is so big already. I haven't removed the logic on plugin-docs also. (doing it now)
There was a problem hiding this comment.
I missed the comment above about @docusaurus/test-utils because this PR has 100+ changed files 🤣
There was a problem hiding this comment.
Been working it for few hours too :| I'll double check again and again lol. ~4,000 lines of code deleted. gg
|
Deploy preview for docusaurus-preview ready! Built with commit c51d902 |
endiliey
changed the title
Motivation
I removed i18n and translation from the codebase. It's better to not ship a WIP code when we release the first alpha public release.
I also did some refactoring with how we deal with some components like
<Head>so that we don't retype the same thing over and over againI also moved all the
testto be co-located with its corresponding files.So the format will be like
Instead of
(Write your motivation here.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
Netlify works
CI Test passes