Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholders where old template READMEs used to be #7972

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Nov 13, 2019

Since there are millions of existing apps out there that link to the old template READMEs we should have a placeholder there that links to the new location.

@@ -39,7 +39,7 @@ function printHostingInstructions(
console.log();
console.log('Find out more about deployment here:');
console.log();
console.log(` ${chalk.yellow('https://create-react-app.dev/docs/deployment')}`);
console.log(` ${chalk.yellow('bit.ly/CRA-deploy')}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the placeholders make sense, but I'd keep this as https://create-react-app.dev/docs/deployment so that the end users don't have to follow 3 links to end up in the same page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever links we put in there basically have to work forever and I don't want to have a long list of old links to keep track of. We have a new domain name that we are going to switch all shortlinks over to.

@iansu iansu merged commit 915108b into facebook:master Nov 13, 2019
@iansu iansu deleted the fix-old-template-readme-links branch November 13, 2019 23:59
@lock lock bot locked and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants