fix: add sideEffects: false to react-error-overlay
#5451
Conversation
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution! |
|
Why have a bot autoclose PRs that hasn't been acknowledged by the maintainers? Not the friendliest thing in the world (I personally don't really care, but it can be disheartening to beginners, methinks) /cc @Timer mind taking a look at this? |
|
Can you please confirm the bundle is byte-for-byte identical when this flag is enabled (well... disabled -- |
|
What bundle do you refer to? An app built with CRA, or the built version of just the overlay? |
|
The dev bundle. |
This allows us to leave the import in the code, and webpack will still tree shake it out
|
Yes, they're identical 🙂 $ yarn create react-app myapp
$ cd myapp
$ yarn start &
$ curl -s http://localhost:3000/static/js/bundle.js | md5
c2e99be9db96e20f22b9bd578cc80fea
$ curl -s http://localhost:3000/static/js/0.chunk.js | md5
07e94a964f183f6edaee07cb113c1e03
$ curl -s http://localhost:3000/static/js/main.chunk.js | md5
09ec1827050bed667003a85530d36ac4
# Change package.json of error overlay, and restart server
$ curl -s http://localhost:3000/static/js/bundle.js | md5
c2e99be9db96e20f22b9bd578cc80fea
$ curl -s http://localhost:3000/static/js/0.chunk.js | md5
07e94a964f183f6edaee07cb113c1e03
$ curl -s http://localhost:3000/static/js/main.chunk.js | md5
09ec1827050bed667003a85530d36ac4 |
|
can't get CI to pass, YOLO |
* upstream/master: (210 commits) Support setupTests.ts (facebook#5698) Remove unnecessary whitespace in template HTML Run prettier on HTML files (facebook#5839) Some Grammar fixes (facebook#5858) Fix link to page about running tests (facebook#5883) fix: make typescriptformatter support 0.5 of fork checker (facebook#5879) Always test with the latest stable Node version on Travis (facebook#5546) Fix propertyDecorator test Upgrade babel deps Fix annotated var test Fix TypeScript decorator support (facebook#5783) fix: add `sideEffects: false` to react-error-overlay (facebook#5451) Add allowESModules option to babel-preset-react-app (facebook#5487) Make named-asset-import plugin work with export-as syntax (facebook#5573) React native repository updated in README.md (facebook#5849) extra polyfills must be included manually (facebook#5814) Rename 'getting started' link to 'docs' (facebook#5806) docs: Simplify installing Storybook with npx (facebook#5788) Don't polyfill fetch for Node -- additional files (facebook#5789) docs: Change Storybook install documentation (facebook#5779) ...
This allows us to leave the import in the code, and webpack will still tree shake it out.
Verified by grepping for
startReportingRuntimeErrorsin the resulting bundle.Note that this is usage outside of
react-dev-utils.Without this change, I need to use
requireand notimport, and stick myrequireinside of an environment check.Docs: https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free