Correctly lookup assets when using a relative build directory #5163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
approved these changes
Sep 28, 2018
|
e2e would be nice |
|
Example broken e2e: joes-mbp:create-react-app joe$ ./node_modules/.bin/jest --config fixtures/smoke/jest.config.js fixtures/smoke/relative-paths/
FAIL fixtures/smoke/relative-paths/index.test.js (22.318s)
relative paths
✕ builds in production (21559ms)
○ skipped 1 test
● relative paths › builds in production
expect(received).toBe(expected) // Object.is equality
Expected: "/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/72a73262107e4b983270278cf537ee30/build/static/media/logo.83ec6b6a.svg"
Received: "/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/72a73262107e4b983270278cf537ee30/build/static/css/static/media/logo.83ec6b6a.svg"
31 | .exec(fs.readFileSync(cssFile, 'utf8'))
32 | .pop();
> 33 | expect(path.resolve(path.join(path.dirname(cssFile), desiredPath))).toBe(
| ^
34 | path.resolve(svgFile)
35 | );
36 | });
at Object.toBe (relative-paths/index.test.js:33:73)
Test Suites: 1 failed, 1 total
Tests: 1 failed, 1 skipped, 2 total
Snapshots: 0 total
Time: 22.367s, estimated 23s
Ran all test suites matching /fixtures\/smoke\/relative-paths\//i.
joes-mbp:create-react-app joe$ |
Timer
commented
Sep 29, 2018
| const buildDir = path.join(global.testDirectory, 'build'); | ||
| const cssFile = path.join( | ||
| buildDir, | ||
| globby.sync('**/*.css', { cwd: buildDir }).pop() |
There was a problem hiding this comment.
This future proofs our file structure.
Timer
commented
Sep 29, 2018
| const desiredPath = /url\((.+?)\)/ | ||
| .exec(fs.readFileSync(cssFile, 'utf8')) | ||
| .pop(); | ||
| expect(path.resolve(path.join(path.dirname(cssFile), desiredPath))).toBe( |
There was a problem hiding this comment.
Resolves it as the browser would.
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
…ok#5163) * Correctly lookup assets when using a relative build directory * Hah, var ... * Add e2e test for relative paths * Format svg
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5162