Fix local testing workflow #3876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Jan 20, 2018
| console.log(); | ||
| console.log('-------------------------------------------------------'); | ||
| console.log('Assuming you have already run `yarn` to update the deps.'); | ||
| console.log('If not, remember to do this before testing!'); |
There was a problem hiding this comment.
Bootstrapping was way too slow and annoying for local testing. Removed it here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
yarn create-react-app ../myproj. It used to fail because we only replaced names with file URLs forreact-scriptdeps. Not it does that for all packages.Happy to change this to work via
npm linklater but for now I just wanted to fix the existing approach.I also made it fail on non-clean repo state, and reset its edits to
package.jsonfiles on exit.