Enhance Jest config error for setupTestFrameworkScriptFile
#3512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wasn't aware of the fact that users of c-r-a could just define `src/setupTests.js` and it would be configured with Jest - I nearly ejected before I found a GitHub issue that confirmed this functionality. I thought it might be a nice idea to add it to the error about Jest config overrides to stop others ejecting when they don't need to.
|
Unless I read the whole message, a quick skim makes it seem like the option is not supported at all and I need to eject. So I don't think this wording makes it much better. :-) Maybe we could tweak the wording? |
gaearon
suggested changes
Jan 9, 2018
|
👍 sounds good, do you have any thoughts on what it should be? Maybe we should re-organise it to first show my additional message about the setup file; and then have the rest of the message? That way the first thing the user reads is "hey you can use setupTestFile!" rather than "no this doesn't work". What do you think? :) |
|
Yep |
|
How does that look? |
|
|
@gaearon thanks for your help :) I've now changed the messages as you suggested. For
For any other config that isn't supported:
|
gaearon
approved these changes
Jan 17, 2018
akstuhl
pushed a commit
to akstuhl/create-react-app
that referenced
this pull request
Mar 15, 2018
…k#3512) * Enhance Jest config error for `setupTestFrameworkScriptFile` I wasn't aware of the fact that users of c-r-a could just define `src/setupTests.js` and it would be configured with Jest - I nearly ejected before I found a GitHub issue that confirmed this functionality. I thought it might be a nice idea to add it to the error about Jest config overrides to stop others ejecting when they don't need to. * Change the order of Jest config errors. * Show different error for `setupTestFrameworkScriptFile` * Tweak the message
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
…k#3512) * Enhance Jest config error for `setupTestFrameworkScriptFile` I wasn't aware of the fact that users of c-r-a could just define `src/setupTests.js` and it would be configured with Jest - I nearly ejected before I found a GitHub issue that confirmed this functionality. I thought it might be a nice idea to add it to the error about Jest config overrides to stop others ejecting when they don't need to. * Change the order of Jest config errors. * Show different error for `setupTestFrameworkScriptFile` * Tweak the message
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't aware of the fact that users of c-r-a could just define
src/setupTests.jsand it would be configured with Jest - I nearlyejected before I found a GitHub issue that confirmed this functionality.
I thought it might be a nice idea to add it to the error about Jest
config overrides to stop others ejecting when they don't need to.