Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints (2/n) #384

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Add type hints (2/n) #384

merged 1 commit into from
Feb 20, 2021

Conversation

KapJI
Copy link
Member

@KapJI KapJI commented Feb 20, 2021

  • Cover process_input.py.
  • Create base class for SimpleLine and LineMatch.
  • Create new type MatchResult.
  • Use TYPE_CHECKING to avoid circular imports. Also from future import ___annotations__ can be used since Python 3.7.

@KapJI KapJI merged commit b381135 into facebook:master Feb 20, 2021
@KapJI KapJI deleted the typing-fixes-2 branch February 20, 2021 22:10
pcottle pushed a commit that referenced this pull request Feb 23, 2022
@KapJI @pcottle
Add type hints (2/n) (#384)
e106622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KapJI @facebook-github-bot