Always predict for status quo features trial index #2810
+47
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63715134 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 2, 2024
Summary:
Previously we had plots that looked like {F1904605463}
After the same plot looks like
{F1904608806}
Differential Revision: D63715134
danielcohenlive
force-pushed
the
export-D63715134
branch
from
1e870e2
to
e4a7fbc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63715134 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D63715134 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 2, 2024
Summary: Pull Request resolved: facebook#2810 Previously we had plots that looked like {F1904605463} After the same plot looks like {F1904608806} Differential Revision: D63715134
danielcohenlive
force-pushed
the
export-D63715134
branch
from
e4a7fbc
to
f936ff5
Compare
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 2, 2024
Summary:
Previously we had plots that looked like {F1904605463}
After the same plot looks like
{F1904608806}
Differential Revision: D63715134
danielcohenlive
force-pushed
the
export-D63715134
branch
from
f936ff5
to
92ea568
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63715134 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 2, 2024
Summary: Pull Request resolved: facebook#2810 Previously we had plots that looked like {F1904605463} After the same plot looks like {F1904608806} Differential Revision: D63715134
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2810 +/- ##
=======================================
Coverage 95.72% 95.72%
=======================================
Files 492 492
Lines 48566 48573 +7
=======================================
+ Hits 46489 46496 +7
Misses 2077 2077 ☔ View full report in Codecov by Sentry. |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 2, 2024
Summary:
Previously we had plots that looked like {F1904605463}
After the same plot looks like
{F1904608806}
Differential Revision: D63715134
danielcohenlive
force-pushed
the
export-D63715134
branch
from
92ea568
to
a4a53d3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63715134 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 2, 2024
Summary:
Previously we had plots that looked like {F1904605463}
After the same plot looks like
{F1904608806}
Differential Revision: D63715134
danielcohenlive
force-pushed
the
export-D63715134
branch
from
a4a53d3
to
fdc33ab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63715134 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 3, 2024
Summary:
Previously we had plots that looked like {F1904605463}
After the same plot looks like
{F1904608806}
Differential Revision: D63715134
danielcohenlive
force-pushed
the
export-D63715134
branch
from
fdc33ab
to
c629a51
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63715134 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 3, 2024
Summary: Pull Request resolved: facebook#2810 Previously we had plots that looked like {F1904605463} After the same plot looks like {F1904608806} Differential Revision: D63715134
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 3, 2024
Summary: Pull Request resolved: facebook#2810 Previously we had plots that looked like {F1904605463} After the same plot looks like {F1904608806} Differential Revision: D63715134
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 3, 2024
Summary:
Previously we had plots that looked like {F1904605463}
After the same plot looks like
{F1904608806}
##What's happening
Because of nonstationarity, the same feature gets predicted differently in different trials. But the point of this plot is to show how well the parameterization does on the metric, so we want to standardize the trial index we're predicting on.
Reviewed By: mgarrard
Differential Revision: D63715134
danielcohenlive
force-pushed
the
export-D63715134
branch
from
c629a51
to
2cc1092
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63715134 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 3, 2024
Summary:
Previously we had plots that looked like {F1904605463}
After the same plot looks like
{F1904608806}
##What's happening
Because of nonstationarity, the same feature gets predicted differently in different trials. But the point of this plot is to show how well the parameterization does on the metric, so we want to standardize the trial index we're predicting on.
Reviewed By: mgarrard
Differential Revision: D63715134
danielcohenlive
force-pushed
the
export-D63715134
branch
from
2cc1092
to
6a98621
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63715134 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 3, 2024
Summary:
Previously we had plots that looked like {F1904605463}
After the same plot looks like
{F1904608806}
##What's happening
Because of nonstationarity, the same feature gets predicted differently in different trials. But the point of this plot is to show how well the parameterization does on the metric, so we want to standardize the trial index we're predicting on.
Reviewed By: mgarrard
Differential Revision: D63715134
danielcohenlive
force-pushed
the
export-D63715134
branch
from
6a98621
to
ba4053e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63715134 |
Summary:
Previously we had plots that looked like {F1904605463}
After the same plot looks like
{F1904608806}
##What's happening
Because of nonstationarity, the same feature gets predicted differently in different trials. But the point of this plot is to show how well the parameterization does on the metric, so we want to standardize the trial index we're predicting on.
Reviewed By: mgarrard
Differential Revision: D63715134
danielcohenlive
force-pushed
the
export-D63715134
branch
from
ba4053e
to
97598bc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63715134 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 3, 2024
Summary: Pull Request resolved: facebook#2810 Previously we had plots that looked like {F1904605463} After the same plot looks like {F1904608806} ##What's happening Because of nonstationarity, the same feature gets predicted differently in different trials. But the point of this plot is to show how well the parameterization does on the metric, so we want to standardize the trial index we're predicting on. Differential Revision: D63715134 Reviewed By: mgarrard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously we had plots that looked like {F1904605463}
After the same plot looks like
{F1904608806}
Differential Revision: D63715134