Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second-order indices support in SobolSensitivity #2788

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hvarfner
Copy link

Summary:
Added support for second order Sobol indices in ax_parameter_sens. Old behavior is unchanged, but:

  • Specifying order="second" gives first- and second-order indices in ax_parameter_sens
  • SobolSensitivity outputs either first- or second-order indices depending on argument
  • Second-order sensitivity requires first-order sensitivity to be computed
  • Keys for second-order indices are a tuple ('param_a'
    , 'param_b')

Differential Revision: D63403218

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 26, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63403218

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63403218

hvarfner pushed a commit to hvarfner/Ax that referenced this pull request Sep 26, 2024
Summary:
Pull Request resolved: facebook#2788

Added support for second order Sobol indices in ax_parameter_sens. Old behavior is unchanged, but:
- Specifying order="second" gives first- and second-order indices in ax_parameter_sens
- SobolSensitivity outputs either first- or second-order indices depending on argument
- Second-order sensitivity requires first-order sensitivity to be computed
- Keys for second-order indices are a tuple ('param_a'
, 'param_b')

Differential Revision: D63403218
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 99.28058% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.71%. Comparing base (78b0527) to head (93191e1).

Files with missing lines Patch % Lines
ax/utils/sensitivity/sobol_measures.py 99.03% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2788   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files         490      490           
  Lines       48555    48606   +51     
=======================================
+ Hits        46472    46522   +50     
- Misses       2083     2084    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63403218

hvarfner pushed a commit to hvarfner/Ax that referenced this pull request Sep 30, 2024
Summary:
Pull Request resolved: facebook#2788

Added support for second order Sobol indices in ax_parameter_sens. Old behavior is unchanged, but:
- Specifying order="second" gives first- and second-order indices in ax_parameter_sens
- SobolSensitivity outputs either first- or second-order indices depending on argument
- Second-order sensitivity requires first-order sensitivity to be computed
- Keys for second-order indices are a tuple ('param_a'
, 'param_b')

Differential Revision: D63403218
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63403218

hvarfner pushed a commit to hvarfner/Ax that referenced this pull request Sep 30, 2024
Summary:
Pull Request resolved: facebook#2788

Added support for second order Sobol indices in ax_parameter_sens. Old behavior is unchanged, but:
- Specifying order="second" gives first- and second-order indices in ax_parameter_sens
- SobolSensitivity outputs either first- or second-order indices depending on argument
- Second-order sensitivity requires first-order sensitivity to be computed
- Keys for second-order indices are a tuple ('param_a'
, 'param_b')

Differential Revision: D63403218
Summary:
Pull Request resolved: facebook#2788

Added support for second order Sobol indices in ax_parameter_sens. Old behavior is unchanged, but:
- Specifying order="second" gives first- and second-order indices in ax_parameter_sens
- SobolSensitivity outputs either first- or second-order indices depending on argument
- Second-order sensitivity requires first-order sensitivity to be computed
- Keys for second-order indices are a string `'param_a & param_b'`

Differential Revision: D63403218
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63403218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants