Fix WithDBSettingsBase to no longer require SQLAlchemy #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: D61338432 accidentally imported from Ax's sql storage module at the top level instead of within the try/except block. This will fix the Nightly job for both Ax and Botorch Reviewed By: Cesar-Cardoso Differential Revision: D61662444
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61662444 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2692 +/- ##
==========================================
- Coverage 95.29% 95.29% -0.01%
==========================================
Files 492 492
Lines 47816 47815 -1
==========================================
- Hits 45567 45564 -3
- Misses 2249 2251 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
D61338432 accidentally imported from Ax's sql storage module at the top level instead of within the try/except block.
This will fix the Nightly job for both Ax and Botorch
Reviewed By: Cesar-Cardoso
Differential Revision: D61662444