Consolidate observe_noise_stds and observe_noise_sd
#2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lems Summary: Context: This will give single-objective and multi-objective benchmark problems a more consistent API, making it possible to simplify the inheritance structure in D60145193 and subsequent PRs. Note: This breaks backwards compatibility, including for reading multi-objective benchmark problems stored as JSON. I think it's worthwhile because this will enable a lot of simplification in the future and because I expect we will want to break backward-compatibility again shortly. It would be possible to make this change BC, but I'm not sure it's worthwhile. Note: Docstrings are updated in D60145193, so they are not updated here. This PR: * Makes `MultiObjectiveBenchmarkProblem.__init__` take an `optimal_value` argument, and removes its `maximum_hypervolume` argument. * Removes the `optimal_value` property of `MultiObjectiveBenchmarkProblem`, which pointed to `maximum_hypervolume`. * Does the same for surrogate benchmark problems. * Updates references to `maximum_hypervolume`. Differential Revision: D60194654
Summary: Context: `observe_noise_stds` was intended to track whether noise is observed on a metric-by-metric level for multi-objective problems. It should be a dict if noise levels are observed for some metrics and not for others. It can also be boolean and be used for single-objective problems. Confusingly, `observe_noise_sd` can be used for single-objective problems. In practice, these are always boolean and identical, because we have neither problems with partially observed noise nor methods for partially observed noise. It's also confusing to keep track of which is present on which problems and what types it might have. In the spirit of YAGNI and to facilitate bringing single-objective and multi-objective problems closer together, this PR removes `observe_noise_stds` and replaces it with with `observe_noise_sd` where appropriate. It is alwayas boolean. If we wind up needing this, we can put it back in, but after more refactoring, the right design might look different. Note: Similar to D60194654, breaks backward compatibility, including for storage. Differential Revision: D60202753
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60202753 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2599 +/- ##
==========================================
- Coverage 95.21% 95.21% -0.01%
==========================================
Files 489 489
Lines 47679 47670 -9
==========================================
- Hits 45399 45390 -9
Misses 2280 2280 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
observe_noise_stdswas intended to track whether noise is observed on a metric-by-metric level for multi-objective problems. It should be a dict if noise levels are observed for some metrics and not for others. It can also be boolean and be used for single-objective problems. Confusingly,observe_noise_sdcan be used for single-objective problems. In practice, these are always boolean and identical, because we have neither problems with partially observed noise nor methods for partially observed noise. It's also confusing to keep track of which is present on which problems and what types it might have.In the spirit of YAGNI and to facilitate bringing single-objective and multi-objective problems closer together, this PR removes
observe_noise_stdsand replaces it with withobserve_noise_sdwhere appropriate. It is alwayas boolean.If we wind up needing this, we can put it back in, but after more refactoring, the right design might look different.
Note: Similar to D60194654, breaks backward compatibility, including for storage.
Differential Revision: D60202753