Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the resume path points to a directory #7919

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Check if the resume path points to a directory #7919

merged 1 commit into from
Apr 28, 2021

Conversation

polm
Copy link
Contributor

@polm polm commented Apr 28, 2021

This came up in #7878, but if --resume-path is a directory then loading
the weights will fail. On Linux this will give a straightforward error
message, but on Windows it gives "Permission Denied", which is
confusing.

Types of change

CLI verification enhancement

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@polm
Check if the resume path points to a directory
8aaac6b 
This came up in explosion#7878, but if --resume-path is a directory then loading
the weights will fail. On Linux this will give a straightforward error
message, but on Windows it gives "Permission Denied", which is
confusing.
@svlandeg svlandeg added feat / cli Feature: Command-line interface feat / tok2vec Feature: Token-to-vector layer and pretraining feat / ux Feature: User experience, error messages etc. labels Apr 28, 2021
@svlandeg svlandeg merged commit 8007d5c into explosion:master Apr 28, 2021
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request May 14, 2021
@polm @adrianeboyd
Check if the resume path points to a directory (explosion#7919)
5bb87bd 
This came up in explosion#7878, but if --resume-path is a directory then loading
the weights will fail. On Linux this will give a straightforward error
message, but on Windows it gives "Permission Denied", which is
confusing.
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request May 19, 2021
@polm @adrianeboyd
Check if the resume path points to a directory (explosion#7919)
08e5fc7 
This came up in explosion#7878, but if --resume-path is a directory then loading
the weights will fail. On Linux this will give a straightforward error
message, but on Windows it gives "Permission Denied", which is
confusing.
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request May 31, 2021
@polm @adrianeboyd
Check if the resume path points to a directory (explosion#7919)
cce4342 
This came up in explosion#7878, but if --resume-path is a directory then loading
the weights will fail. On Linux this will give a straightforward error
message, but on Windows it gives "Permission Denied", which is
confusing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feat / cli Feature: Command-line interface feat / tok2vec Feature: Token-to-vector layer and pretraining feat / ux Feature: User experience, error messages etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polm @svlandeg