Prepare for v2. Update config.json and ABOUT.md. Refs #569 #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSchierboom
requested changes
Jun 12, 2018
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "language": "Scala", | |||
| "active": true, | |||
| "blurb": "", | |||
| "blurb": "Scala combines object-oriented and functional programming in one concise, high-level language. Scala's static types help avoid bugs in complex applications, and its JVM and JavaScript runtimes let you build high-performance systems with easy access to huge ecosystems of libraries.", | |||
There was a problem hiding this comment.
I think to huge ecosystems should be two huge ecosystems
| @@ -1,3 +1,8 @@ | |||
| Scala is a object-oriented, functional language that runs on the Java Virtual Machine (JVM). It was created by Martin Odersky. | |||
| Scala combines object-oriented and functional programming in one concise, high-level language. Scala's static types help avoid bugs in complex applications, and its JVM and JavaScript runtimes let you build high-performance systems with easy access to huge ecosystems of libraries. | |||
There was a problem hiding this comment.
I think to huge ecosystems should be two huge ecosystems
There was a problem hiding this comment.
I lifted this text from the Scala web site. I think 'to' is what they had in mind. Not the number 2.
docs/ABOUT.md
Outdated
| Scala is a portmanteau of “Scalable Language”, which is said to mean (by the official website) that the language scales with you. | ||
| * Features | ||
| * JVM Interoperability - Scala runs on the JVM, so Java and Scala stacks can be mixed for seamless integration. | ||
| * Type Inference - Scala is statically typed. But, Scala provides type inference to ease the burden of an advanced type system. |
There was a problem hiding this comment.
But, Scala provides might be rephrased to However, Scala provides
There was a problem hiding this comment.
Agreed. This is much better. I will make this change.
Thanks
Integrate suggestion to change 'But' to 'However'.
ErikSchierboom
approved these changes
Jun 12, 2018
|
Just waiting for the build to become green (I'm on my phone) |
|
Thanks! |
|
Thanks Erik!
…On Tue, Jun 12, 2018 at 8:41 AM Erik Schierboom ***@***.***> wrote:
Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#570 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABeHG9F36n70HixeQmvfaSfsL4mxFr0oks5t7-EwgaJpZM4Ujvqr>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for v2. Update config.json and ABOUT.md. Refs #569