Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEVPROD-10420: do not link patch_optional dependencies for alias versions #8348

Merged
merged 11 commits into from
Sep 27, 2024
Merged

DEVPROD-10420: do not link patch_optional dependencies for alias versions #8348

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a28b200
WIP testing patch optional ghost dependency
Kimchelly Sep 24, 2024
0604e7e
Add notes about task ID table and patch_optional dependencies
Kimchelly Sep 26, 2024
a13e3a3
Add tentative logic to filter task IDs down for alias-selected waterf…
Kimchelly Sep 26, 2024
a33ea88
Add unit tests
Kimchelly Sep 26, 2024
770020e
Add test for task group behavior
Kimchelly Sep 26, 2024
1e33e52
Revert self-tests back to original
Kimchelly Sep 26, 2024
e688de4
Clarify patch_optional docs
Kimchelly Sep 27, 2024
d213f42
Add safety check just in case task ID is missing
Kimchelly Sep 27, 2024
cad913e
Make debug log more useful
Kimchelly Sep 27, 2024
819d2a1
Spelling
Kimchelly Sep 27, 2024
d64b670
CR
Kimchelly Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert self-tests back to original
  • Loading branch information
@Kimchelly
Kimchelly committed Sep 26, 2024
commit 1e33e52e8a82444c931ddc08228ce2afb278801f
10 changes: 0 additions & 10 deletions self-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,14 +536,6 @@ tasks:
- <<: *run-go-test-suite
tags: ["nodb", "test"]
name: test-util
depends_on:
- name: kim-patch-optional
patch_optional: true
- name: kim-patch-optional
commands:
- command: shell.exec
params:
script: echo hello world
- <<: *run-go-test-suite-with-mongodb
tags: ["db", "test"]
name: test-validator
Expand Down Expand Up @@ -820,7 +812,6 @@ buildvariants:
- name: "js-test"
- name: generate-api-docs
- name: write-downstream-expansions-for-pine
- name: kim-patch-optional

- name: race-detector
display_name: Race Detector
Expand All @@ -836,7 +827,6 @@ buildvariants:
test_timeout: 15m
tasks:
- name: ".test"
- name: kim-patch-optional

- name: ubuntu2004-container
display_name: Ubuntu 20.04 (Container)
Expand Down