Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEVPROD-11617: Sort waterfall build variants alphabetically #8343

Merged
merged 2 commits into from
Sep 26, 2024
Merged

DEVPROD-11617: Sort waterfall build variants alphabetically #8343

merged 2 commits into from
Sep 26, 2024

Conversation

sophstad
Copy link
Contributor

@sophstad sophstad commented Sep 25, 2024 •
edited
Loading

DEVPROD-11617

Description

  • Fix previous implementation of waterfall sorting that sorted builds by their ID. We should sort by display name, especially since a lot of projects have their display names configured to render on the waterfall in a useful order.

Testing

  • Update test such that it would fail without display name sorting

@sophstad sophstad changed the title DEVPROD-11617: Sort build variants alphabetically DEVPROD-11617: Sort waterfall build variants alphabetically Sep 25, 2024
@sophstad sophstad marked this pull request as ready for review September 25, 2024 17:52
@sophstad sophstad requested a review from a team September 25, 2024 17:52
@sophstad sophstad merged commit 620c59c into evergreen-ci:main Sep 26, 2024
10 checks passed
@sophstad sophstad deleted the DEVPROD-11617 branch September 26, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ablack12 ablack12 ablack12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophstad @ablack12