DEVPROD-9663 remove incorrect patch permission text and update superuser default #8336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimchelly
approved these changes
Sep 23, 2024
|
@Kimchelly sorry I added a one line change to also update the local default for consistency, would you mind re-reviewing? |
ablack12
changed the title
Kimchelly
approved these changes
Sep 23, 2024
|
Updating testdata/local seems to be breaking spruce tests, so I'm actually going to pull that back and split a ticket (https://jira.mongodb.org/browse/DEVPROD-11585) |
This reverts commit f717ab8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-9663
Description
This text says there's no permission to "view or edit patches", but we actually use task view permission for all viewing things, and we only use this for submission, so this shouldn't reference view.
Verified there's nothing to update for mana, since this already just says "unspecified".