DEVPROD-9923: remove Evergreen client on MacOS task hosts #8263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadjri
reviewed
Sep 4, 2024
model/distro/distro.go
Outdated
| func (d *Distro) IsWindows() bool { | ||
| // XXX: if this is-windows check is updated, make sure to also update | ||
| // public/static/js/spawned_hosts.js as well | ||
| return strings.Contains(d.Arch, "windows") | ||
| } | ||
|
|
||
| // IsWindows returns whether or not the distro's hosts run on Linux. |
There was a problem hiding this comment.
Nice catch, fixed.
|
|
||
| require.NoError(t, m.removeMacOSClient()) | ||
| _, err = os.Stat(m.clientPath) | ||
| if runtime.GOOS == "darwin" { |
There was a problem hiding this comment.
Slightly tangential but our MacOS variant is inactive. Should we enable it for the sake of affirming these sorts of tests?
There was a problem hiding this comment.
Good call, I activated it.
hadjri
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-9923
Description
The MacOS hosts have recently had trouble deploying new agent binaries. The suspected issue is that some of the MacOS hosts have SIP enabled, and those hosts are SIGKILL'ing the binary if it has some issue (such as running with CGO enabled or running an Evergreen binary that hasn't been signed by Apple). This problem persists even if a new version is downloaded that fixes the original issue - the binary still gets SIGKILL'd after redownloading a valid Evergreen agent to the file path. The workaround we found (that was found long ago during an identical outage) was to
rmthe binary, which seemed to fix the issue.Testing
Documentation
N/A