DEVPROD-10123 Consistently case admin and project banners #8222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ablack12
approved these changes
Aug 26, 2024
ZackarySantana
pushed a commit
to ZackarySantana/evergreen
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-10123
Description
When we added project banners, we used uppercase for the GraphQL enum. But admin
banners use a lowercase type. This PR makes the admin banner also use an
uppercase type. It also ensures that both uppercase and lowercase have the same
behavior in the legacy JavaScript so that we can safely deploy this commit.
Testing
Tested in staging.