DEVPROD-9133 only run maxprocs for the app servers #8129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimchelly
approved these changes
Jul 23, 2024
| @@ -48,6 +49,9 @@ func startWebService() cli.Command { | |||
| Action: func(c *cli.Context) error { | |||
| ctx, cancel := context.WithCancel(context.Background()) | |||
|
|
|||
| _, err := maxprocs.Set() | |||
There was a problem hiding this comment.
Can we add a comment on what max procs is needed for? Otherwise it looks like a random/unnecessary bit of logic and future readers might wonder what's so important about it that it warrants grip.EmergencyFatal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-9133
Description
It looks like maxprocs assumes
cfs_quota_usandcfs_period_usare set, which in turn depend on theCONFIG_CFS_BANDWIDTHkernel configuration option. This was added to modern versions of Debian, but not Jessie.This PR moves setting GOMAXPROCS into
startWebService()so it'll only happen in the app servers (and smoke tests and whatever), which should only be running on modern versions of Linux.Testing
The app server started successfully in staging, and GOMAXPROCS was set appropriately.