DEVPROD-7728 Remove unused constants #7936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimchelly
requested changes
May 30, 2024
service/middleware.go
Outdated
| const ( | ||
| ProjectCookieName string = "mci-project-cookie" | ||
|
|
||
| // Key values used to map user and project data to request context. | ||
| // These are private custom types to avoid key collisions. | ||
| RequestTask reqCtxKey = iota | ||
| RequestProjectContext |
There was a problem hiding this comment.
This has to be assigned a value, even if it's just reqCtxKey = iota, no? Or else it'll be assigned the same value as the const above it (mci-project-cookie).
Kimchelly
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-7728
Description
These constants came up as unused in a code analyzer tool and they are all old so they should be safe to remove.
Testing
Existing tests