Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVG-6201 Don't print update message while updating #2783

Merged
merged 3 commits into from
Oct 16, 2019
Merged

EVG-6201 Don't print update message while updating #2783

merged 3 commits into from
Oct 16, 2019

Conversation

bsamek
Copy link
Contributor

@bsamek bsamek commented Oct 15, 2019

No description provided.

Copy link
Contributor

@john-m-liu john-m-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding this in every command, what if we used grip to log the message but set the sender to a noop one in the update command? You would also need to change the banner message so that it always displays

@tychoish
Copy link
Contributor

I like John's idea.

@bsamek
Copy link
Contributor Author

bsamek commented Oct 16, 2019

@john-m-liu @tychoish We don't want to not log in the update command though. Is there a way to do this temporarily?

@john-m-liu
Copy link
Contributor

What if you change it before getting the communicator and change it back afterwards?

@bsamek
Copy link
Contributor Author

bsamek commented Oct 16, 2019

What if you change it before getting the communicator and change it back afterwards?

I don't like this solution, because it works around a problem where a single function is surprisingly doing multiple things by manipulating the logger. I've pushed a different solution, where a function wraps getting the communicator and printing messages, which I am considering all to be part of setting up communication with Evergreen.

@bsamek bsamek merged commit 3f4513b into evergreen-ci:master Oct 16, 2019
@bsamek bsamek deleted the EVG-6201-cli-get-update branch October 16, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants