EVG-3358: use gimlet app for restv1 #1166
Conversation
service/service.go
Outdated
| legacyApp.AddMiddleware(negroni.HandlerFunc(UserMiddleware(as.UserManager))) | ||
| legacyApp.AddMiddleware(negroni.NewStatic(http.Dir(filepath.Join(uis.Home, "public")))) | ||
|
|
||
| router, err := legacyApp.Router() |
There was a problem hiding this comment.
the app needs to be resolved before this I think
service/api_task_test.go
Outdated
| @@ -77,7 +77,7 @@ func getEndTaskEndpoint(t *testing.T, as *APIServer, hostId, taskId string, deta | |||
|
|
|||
| handler, err := as.Handler() | |||
| if err != nil { | |||
| t.Fatalf("creating test API handler: %v", err) | |||
| t.Fatalf("cyreating test API handler: %v", err) | |||
|
|
||
| func (ra *restV1middleware) ServeHTTP(rw http.ResponseWriter, r *http.Request, next http.HandlerFunc) { | ||
| vars := gimlet.GetVars(r) | ||
| ctx, err := model.LoadContext(vars["task_id"], vars["build_id"], vars["version_id"], vars["patch_id"], vars["project_id"]) |
There was a problem hiding this comment.
project can also be stored in a cookie rather than the url (see the old getRequestProjectId func)
There was a problem hiding this comment.
as discussed in person, this is only true of the UI server, which has a very similar method.
| return | ||
| } | ||
|
|
||
| if ctx.ProjectRef != nil && ctx.ProjectRef.Private && GetUser(r) == nil { |
There was a problem hiding this comment.
this feels like it belongs elsewhere, either in an auth method or in the route itself
There was a problem hiding this comment.
I think better to keep this out of the route itself, and also, I totally agree with you, but the problem is that this has to happen really late in the process (on the whole), so it might not get much better than this.
tychoish
force-pushed
the
EVG-3358-use-gimlet-for-restv1
branch
from
e4f176c
to
0ce4f5b
Compare
|
|
||
| const RestContext restContextKey = 0 | ||
|
|
||
| type restAPIService interface { |
There was a problem hiding this comment.
I feel like this interface shouldn't exist, but I also can't think of a cleaner way to do this :/
There was a problem hiding this comment.
I couldn't agree more. Some day we'll fix it.
tychoish
force-pushed
the
EVG-3358-use-gimlet-for-restv1
branch
from
f01ade3
to
11d45c4
Compare
No description provided.