BAEL-1196: jUnit @Test Annotation #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinGilmore
requested changes
Dec 6, 2017
| * @author Donato Rimenti | ||
| * | ||
| */ | ||
| public class NumbersBeanTest { |
There was a problem hiding this comment.
Let's rename the test class as per convention: NumbersBeanUnitTest
| * Tests that when an even number is passed to | ||
| * {@link NumbersBean#isNumberEven(int)}, true is returned. | ||
| */ | ||
| @Test |
There was a problem hiding this comment.
Better test names, using the givenX_whenY_thenZ formula, would be:
givenEvenNumber_whenCheckingIsNumberEven_thenTrue
givenOddNumber_whenCheckingIsNumberEven_thenFalse
KevinGilmore
approved these changes
Dec 6, 2017
tarangbhalodia
pushed a commit
to tarangbhalodia/tutorials
that referenced
this pull request
Jan 2, 2018
* BAEL-1196: jUnit @test Annotation * Fixed tests names as suggested. * Reduced visibility on test methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.