Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass vector of SMT expressions to SymbolicFunctionVariable function operator by const ref instead of by value. #14981

Conversation

zo9999
Copy link
Contributor

@zo9999 zo9999 commented Apr 3, 2024

To avoid the cost of copying the vector.

Copy link

github-actions bot commented Apr 3, 2024

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@ekpyron ekpyron requested a review from blishko August 15, 2024 12:38
operator by const ref instead of by value

To avoid the cost of copying the vector
@blishko blishko force-pushed the fix-signature-of-function-operator-for-symbolic-function-variable branch from d94555a to b9b1d08 Compare August 15, 2024 13:46
Copy link
Contributor

@blishko blishko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can take this parameter by reference to avoid the extra copy.

@blishko blishko merged commit fc0fb95 into ethereum:develop Aug 15, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants