Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status bar updates #4960

Merged
merged 25 commits into from
Jul 15, 2024
Merged

Status bar updates #4960

merged 25 commits into from
Jul 15, 2024

Conversation

joeizang
Copy link
Collaborator

@joeizang joeizang commented Jul 5, 2024

fixes #4949

@joeizang joeizang added the WIP label Jul 5, 2024
@joeizang joeizang self-assigned this Jul 5, 2024
Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit ae8b10e
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/669562a27f4b1f0008b71fe0
😎 Deploy Preview https://deploy-preview-4960--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joeizang joeizang requested review from LianaHus and ryestew July 8, 2024 13:42
@joeizang joeizang added ready-to-review PR ready to review and removed WIP labels Jul 8, 2024
@LianaHus
Copy link
Collaborator

LianaHus commented Jul 9, 2024

All changes look good.
But (sorry) I just discovered we have a UX issue with the copilot label.
It is a bit confusing why it is there.

  • if this is the same as the switch near the robot, maybe it should look the same. and why we should have two.
    And then it should be really disabled
    image

  • If this is just a status then "Copilot is disabled" should be the label and not the tooltip and the tooltip should explain how to switch it on

@LianaHus
Copy link
Collaborator

LianaHus commented Jul 9, 2024

lightbulb maybe should be success, warning should be reserved for potential problems. info will do but the background is using blue

@LianaHus
Copy link
Collaborator

I'm approving this but the tooltip should be discussed at ux meeting

@joeizang joeizang merged commit 9237095 into master Jul 15, 2024
33 checks passed
@joeizang joeizang deleted the statusbar-updates branch July 15, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status bar updates
2 participants