Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piper/config simplification #396

Merged

Conversation

pipermerriam
Copy link
Member

@pipermerriam pipermerriam commented Dec 1, 2017

This is part of #395

What was wrong?

  • Populus level config was unnecessarily written to disk when not present. Non-ideal default behavior as it makes upgrading harder when nothing has changed, requiring that we overwrite the previous config.
  • Project level config doesn't actually need to exist since it's just defaults. Users can fill this in with config values when they need them.
  • References within config files are problematic.

How was it fixed?

This is a first step towards fixing these issues.

  • Remove all config values from project config file that are default, or remove the whole file if it's nothing but defaults.
  • Remove all config values from populus config file that are default, or remove the whole file if it's nothing but defaults.
  • Remove the functionality that creates the populus config file.
  • Remove support for references and deference all existing references.

Cute Animal Picture

put a cute animal picture here.

@pipermerriam pipermerriam merged commit 1c9c65a into ethereum:master Dec 12, 2017
@pipermerriam pipermerriam deleted the piper/config-simplification branch December 12, 2017 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant