consensus, core, ethstats: use engine specific block beneficiary #14318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
force-pushed
the
engine-agnostic-beneficiary
branch
from
b7c81ca
to
2bdc019
Compare
Arachnid
approved these changes
Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While executing transaction, the current code had the recipient of the gas fees set as the
coinbasefield from the header. This however only holds true forethash, but not forcliqueand probably won't hold forcaspereither. Any consensus scheme that is based on signatures needs to actually derive the "miner" address and won't have a field pre-set (that would be redundant data).This PR ensures that transaction processing has access to the consensus engine, and the
coinbaseaccount while running transactions isn't taken directly from the header, rather it delegates extracting the coinbase to the specific consensus engine. An annoying "corner case" for signature based engines is that the header does not yet contain the signature during mining, so the miner's address needs to be explicitly specified during block minting.The PR also adds a minor polish to ethstats to it reports the newly derived block author field and not the current header coinbase.