EL-triggered consolidations #3775
Conversation
Co-authored-by: Mikhail Kalinin <[email protected]>
This reverts commit dc2a2bd.
| if source_index == target_index: | ||
| return |
There was a problem hiding this comment.
would it be more straightforward to use if request_source_pubkey == request_target_pubkey here?
There was a problem hiding this comment.
I don't have a strong opinion here. Whatever we choose, we do use source_index and target_index later and it probably makes sense to define them
| if get_consolidation_churn_limit(state) <= MIN_ACTIVATION_BALANCE: | ||
| return |
There was a problem hiding this comment.
test case idea: have a validator get partial withdrawal and then process its consolidation at the same block.
There was a problem hiding this comment.
LGTM! 👍
We already have consolidation smart contract implementation (lightclient/sys-asm#14). The other missing part is the EL specification, and IMO it would be reasonable to wait for the decision on the alternative proposal to EIP-7685, which is drafted and explained here: ethereum/execution-apis#551. The proposal does also affects CL as it would need to keep all requests in the BeaconBlockBody instead of the ExecutionPayload structure.
…layer_withdrawal_request`
As decided prior to the interop, we want to move to EL-triggered consolidations, to simplify the way this feature affects staking pools. Like withdrawal requests, consolidation requests go in the execution payload, and processing failures result in a no-op instead of an invalid block.