run tests against future forks by default #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
reviewed
Sep 29, 2021
| @@ -45,7 +48,7 @@ def wrap(flag: AtomicBoolean): | |||
| assert is_called.value | |||
|
|
|||
|
|
|||
| @with_phases([MERGE]) | |||
| @with_merge_and_later | |||
There was a problem hiding this comment.
I thought test_on_merge_block.py tests are MERGE-phase-only?
/cc @zilm13
There was a problem hiding this comment.
TBH, I'm not 100% sure on these, I'll revert the test_on_merge_block.py changes for now until there is clarity.
dapplion
approved these changes
Sep 29, 2021
Some tests are currently restricted to a single phase using @with_phases even though they could likely run unchanged in later phases. This patch changes the default for such tests to also run in later phases. If the beacon chain changes enough in later phases to break these tests, this highlights that the tests need to be adjusted or extended accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests are currently restricted to a single phase using @with_phases
even though they could likely run unchanged in later phases. This patch
changes the default for such tests to also run in later phases. If the
beacon chain changes enough in later phases to break these tests, this
highlights that the tests need to be adjusted or extended accordingly.