This repository has been archived by the owner on Apr 24, 2022. It is now read-only.
Fix process extra nonce out of range exception #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix process extra nonce out of range exception
MariusVanDerWijden
approved these changes
Jun 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now after resize extra nonce to 16 bytes, the std::stoul will raise exception "stoul argument out of range".
Because if server send extra nonce to "abcabc", after run enonce.resize(16, '0');
enonce will be "abcabc0000000000" in hex, it already exceed the max value of uint32_t, need to use the 64 bit version std::stoull to convert hex string to uint64_t type.
C++ reference
https://en.cppreference.com/w/cpp/string/basic_string/stoul