Fix atom_to_binary to use pre-allocated binary (Reopened) #8631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucioleKi
added
the
testing
CT Test Results 3 files 141 suites 50m 31s ⏱️ For more details on these failures, see this check. Results for commit 7a4e9e7. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
jhogberg
removed
the
testing
lucioleKi
added
the
testing
lucioleKi
added
testing
lucioleKi
force-pushed
the
atom_to_binary
branch
from
9d0aba7
to
71cda59
Compare
lucioleKi
removed
the
testing
`erl_global_literals` has been redesigned to be more dynamic, allowing any global literal to be created, rather than a small set of literals. Lambdas for exports will now use this interface. The next commit will change atoms to also do that.
lucioleKi
force-pushed
the
atom_to_binary
branch
from
71cda59
to
7a4e9e7
Compare
lucioleKi
added
the
testing
When an atom is created, we now create a binary literal of it, so that atom_to_binary returns the pre-allocated binary literal instead of a newly converted one.
lucioleKi
force-pushed
the
atom_to_binary
branch
from
7a4e9e7
to
d1fca18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #8615. I merged the previous one by mistake before it was ready.
When an atom is created, we now create a binary literal of it, so that atom_to_binary returns the pre-allocated binary literal instead of a newly converted one.
In atom.h, the name field in the atom struct is changed to a union of an original name (byte*) and an Eterm binary. The former is used by templates when creating an atom. The latter is used when the atom is in the table, therefore also for atom_to_binary.
erl_global_literals.handerl_global_literals.care also redesigned. Previously, lambdas inexport.cand atoms inatom.cboth allocate literal areas separately, without using the global literals interface. Now they both use the new interface oferl_global_literals, so that literal areas are allocated and registered in the same way for lambdas, atoms, and all other global literals. Helper functions likeatom_text_alloc()andmore_atom_areas()are removed from atom.c, as they are now handled by functions inerl_global_literals.c.