Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: use absolute path when applying exclude regex #1902

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

lupin012
Copy link
Contributor

@lupin012 lupin012 commented Mar 10, 2024

After #1885 I started to experience linking errors on my machine for targets snapshots and db_toolbox. The problem was caused by library silkworm_node being empty, which in turn was due to a combination of two things:

  • one of my Silkworm repo stays in external disk and contains db folder in parent path (i.e. /db/silkworm/...)
  • the exclude regex application in silkworm_library CMake function excluded all source files for such weird path

I've added SILKWORM_SRC_DIR in each exclude regex token to filter using absolute paths.

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.24%. Comparing base (7b9c76c) to head (ee5ef88).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1902      +/-   ##
==========================================
+ Coverage   52.22%   52.24%   +0.01%     
==========================================
  Files         607      607              
  Lines       45554    45554              
  Branches     7034     7034              
==========================================
+ Hits        23792    23800       +8     
+ Misses      19680    19676       -4     
+ Partials     2082     2078       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@canepat canepat changed the title Ci/fix in exclude regx mgt cmake: use project path when applying exclude regex Mar 10, 2024
@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Mar 10, 2024
@canepat canepat changed the title cmake: use project path when applying exclude regex cmake: use absolute path when applying exclude regex Mar 10, 2024
@canepat canepat merged commit 6f46e81 into master Mar 11, 2024
15 checks passed
@canepat canepat deleted the ci/fix_in_EXCLUDE_REGX_mgt branch March 11, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants