Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshots seg: library target #1807

Merged
merged 1 commit into from
Feb 12, 2024
Merged

snapshots seg: library target #1807

merged 1 commit into from
Feb 12, 2024

Conversation

battlmonstr
Copy link
Contributor

@battlmonstr battlmonstr commented Feb 7, 2024 •
edited
Loading

  • make snapshots::seg a separate library
  • convert node to use silkworm_library()
  • change run_unit_test_loop.py to work with any test executables instead of hardcoding target names

@battlmonstr battlmonstr mentioned this pull request Feb 9, 2024
Merged
@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Feb 12, 2024
@canepat canepat merged commit 60f0b46 into master Feb 12, 2024
4 checks passed
@canepat canepat deleted the pr/snap_decomp4 branch February 12, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canepat canepat canepat approved these changes

Assignees
No one assigned
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@battlmonstr @canepat