Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream_info: encapsulate response_code_ #29012

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

kyessenov
Copy link
Contributor

Commit Message: Use the existing accessors instead of the direct field.
Risk Level: low
Testing:
Docs Changes: none
Release Notes: none

Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, LGTM. Thanks. Check CI please and then we can merge it.

@kyessenov
Copy link
Contributor Author

/retest
(timeout in big test)

@kyessenov kyessenov merged commit d3c384a into envoyproxy:main Aug 15, 2023
115 checks passed
phlax added a commit to phlax/envoy that referenced this pull request Aug 17, 2023
mum4k pushed a commit to envoyproxy/nighthawk that referenced this pull request Aug 23, 2023
- Update the ENVOY_COMMIT and ENVOY_SHA in bazel/repositories.bzl to the latest Envoy's commit.
- Update to .bazelrc to envoyproxy/envoy#29145
- Update .bazelversion to envoyproxy/envoy#29057
- Update ci/run_envoy_docker.sh to envoyproxy/envoy#26049
- Update source/client/stream_decoder.cc to envoyproxy/envoy#29012
- Update build rules to support envoyproxy/envoy#29122

Signed-off-by: tomjzzhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants