This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Fix: ensure instance attachments are loaded in draw widget #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
approved these changes
Mar 23, 2023
eyelidlessness
force-pushed
the
fix/draw-widget-load-instance-attachments
branch
from
5d08778
to
6f3877f
Compare
lognaturel
approved these changes
Mar 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've validated this change locally in Enketo Express. There's a deeper underlying issue that I'd like to address separately, prioritizing the quick fix for now. The underlying issue: when loading a submission,
dataLoadedUrlis set on a different input element thanDrawWidget#element.