Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build step #66

Merged
merged 5 commits into from
Apr 30, 2020
Merged

Add build step #66

merged 5 commits into from
Apr 30, 2020

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Apr 30, 2020

Adds a package & docs build step, that is also included by the Test Suite.

@tomchristie
Copy link
Member Author

Right, I'm a little confused that the docs build passed here, but not on https://github.com/encode/httpcore/runs/632770963?check_suite_focus=true but this gets us to a better place anyways.

@tomchristie tomchristie merged commit cfde059 into master Apr 30, 2020
@tomchristie tomchristie deleted the add-build-step branch April 30, 2020 10:45
@yeraydiazdiaz
Copy link
Contributor

yeraydiazdiaz commented Apr 30, 2020

I think it's because we now run the install script which includes pip install -e .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants